[Streaming][Doc][Minor] Update the description of direct Kafka stream doc#10246
[Streaming][Doc][Minor] Update the description of direct Kafka stream doc#10246jerryshao wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #47490 has finished for PR 10246 at commit
|
|
LGTM |
|
Thanks @jerryshao. Merging to master, 1.6, 1.5, 1.4. |
… doc With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise. zsxwing tdas , please review, thanks a lot. Author: jerryshao <sshao@hortonworks.com> Closes #10246 from jerryshao/direct-kafka-doc-update. (cherry picked from commit 24d3357) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
… doc With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise. zsxwing tdas , please review, thanks a lot. Author: jerryshao <sshao@hortonworks.com> Closes #10246 from jerryshao/direct-kafka-doc-update. (cherry picked from commit 24d3357) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
… doc With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise. zsxwing tdas , please review, thanks a lot. Author: jerryshao <sshao@hortonworks.com> Closes #10246 from jerryshao/direct-kafka-doc-update. (cherry picked from commit 24d3357) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
|
Hi @zsxwing, one of the feature "message handler" is only supported in 1.6. So maybe better not merge back to the previous version :). |
Is |
|
No, it is not mentioned in the doc. What I mean is that for previous version, Python api still miss this piece of functionality, so correcting this description in the previous version is not exactly correct. |
|
But it will be confusing if we say We don't mention if we support a custom message handler in the doc. Even if Python api didn't support the message handler in 1.4 and 1.5, we can still say Python api supports the Kafka direct stream. Right? |
With the merge of SPARK-8337, now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise.
@zsxwing @tdas , please review, thanks a lot.